aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966315547
##########
core/src/main/java/org/apache/iceberg/avro/PruneColumns.java:
##########
@@ -92,7 +93,8 @@ public Schema record(Schema record, List<String> names,
List<Schema> fields) {
hasChange = true; // Sub-fields may be different
filteredFields.add(copyField(field, fieldSchema, fieldId));
} else {
- if (isRecord(field.schema())) {
+ if (isRecord(field.schema())
+ && field.schema().getLogicalType() != VariantLogicalType.get()) {
Review Comment:
I did that and reverted, thought that would confuse. But I guess it's only
used in this class and it would be fine. Let me move to isRecord().
You are right. I shouldn't use != to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
