aihuaxu commented on code in PR #12238:
URL: https://github.com/apache/iceberg/pull/12238#discussion_r1966427898
##########
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java:
##########
@@ -187,6 +187,21 @@ public Schema map(Types.MapType map, Schema keySchema,
Schema valueSchema) {
return mapSchema;
}
+ @Override
+ public Schema variant() {
+ String recordName = "r" + fieldIds.peek();
Review Comment:
Basically in RemoveIds we have the following to add "table" as the name. I
was trying to keep them in sync when I found for the test but I reverted and
just updated the test.
> static Schema removeIds(org.apache.iceberg.Schema schema) {
> return AvroSchemaVisitor.visit(
> AvroSchemaUtil.convert(schema.asStruct(), "table"), new
RemoveIds());
> }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
