swapna267 commented on code in PR #12191:
URL: https://github.com/apache/iceberg/pull/12191#discussion_r1990251133
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceSql.java:
##########
@@ -53,7 +55,11 @@ public class TestIcebergSourceSql extends TestSqlBase {
@BeforeEach
@Override
public void before() throws IOException {
- TableEnvironment tableEnvironment = getTableEnv();
+ setUpTableEnv(getTableEnv());
Review Comment:
Yes Source watermarks are being called on Source only in streaming env.
For iceberg source even in Batch mode, it would still be important to
configure a watermark column, so the splits are sorted. But
applySourceWatermark is not being called in batch env.
More details here,
https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/dev/datastream/execution_mode/#event-time--watermarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
