nastra commented on code in PR #12635:
URL: https://github.com/apache/iceberg/pull/12635#discussion_r2011541654
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -414,6 +416,10 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
authManager.tableSession(finalIdentifier, tableConf,
contextualSession);
TableMetadata tableMetadata;
+ if (tableSession instanceof OAuth2Util.AuthSession) {
Review Comment:
I don't think I fully follow why this change is needed. If a REST server
supports a sub-scoped table token, then the server would return this via the
`token` field in `LoadTableResponse#config` and so you would end up having a
properly configured `tableSession` (which already takes in the `tableConf` with
the potentially sub-scoped table token).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
