wolflex888 commented on code in PR #12635:
URL: https://github.com/apache/iceberg/pull/12635#discussion_r2014527462
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -414,6 +416,10 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
authManager.tableSession(finalIdentifier, tableConf,
contextualSession);
TableMetadata tableMetadata;
+ if (tableSession instanceof OAuth2Util.AuthSession) {
Review Comment:
Since we are already getting a `tableSession` that's dedicated to interact
with the table from the REST server. will it make more sense to pass it down to
`VendedCredentialsProvider` instead of expecting `LoadTableResponse.config()`
to include that property? This is just a proposal, I'm still trying to figure
out how iceberg should interact with a REST server, `Apache Polaris` in our
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
