nastra commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2026386565
##########
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java:
##########
@@ -47,6 +48,16 @@
import software.amazon.awssdk.services.iam.model.PutRolePolicyRequest;
import software.amazon.awssdk.services.s3.model.S3Exception;
+@EnableAwsTest(
+ required = {
+ AwsIntegTestUtil.AWS_ACCESS_KEY_ID,
+ AwsIntegTestUtil.AWS_SECRET_ACCESS_KEY,
+ AwsIntegTestUtil.AWS_SESSION_TOKEN,
+ AwsIntegTestUtil.AWS_TEST_ACCOUNT_ID,
+ AwsIntegTestUtil.AWS_REGION,
+ AwsIntegTestUtil.AWS_TEST_BUCKET
+ })
+@ExtendWith(EnableAwsTestCondition.class)
Review Comment:
could you please try and see whether we can achieve the same thing by using
`EnabledIfEnvironmentVariables`? This would be more straightforward and easier
to read/understand when the tests should be executed. Also we don't need to
introduce any new classes/annotations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
