lliangyu-lin commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2027542721
##########
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java:
##########
@@ -47,6 +49,14 @@
import software.amazon.awssdk.services.iam.model.PutRolePolicyRequest;
import software.amazon.awssdk.services.s3.model.S3Exception;
+@EnabledIfEnvironmentVariables({
Review Comment:
Discussed with @xiaoxuandev offline. Since we are mixing other issues on
this PR, I think we are good with moving with environment variables approach
and close out on moving the docker based tests first.
I will follow up with separate PRs to address other concerns in the AWS
integration tests. I have created this
[issue](https://github.com/apache/iceberg/issues/12715) to track.
cc: @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
