pvary commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r2026554669
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1772,6 +1775,24 @@ public void testNoSchemasOrSpecsToRemove() {
.anyMatch(u -> u instanceof
MetadataUpdate.RemoveSchemas)));
}
+ @TestTemplate
+ public void testCustomWorkerPool() {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
+ // shutdown the executor, cleanExpiredSnapshots should fail
+ executor.shutdownNow();
+ RemoveSnapshots removeSnapshots = (RemoveSnapshots)
removeSnapshots(table).planWith(executor);
+
+ table.newAppend().appendFile(FILE_A).commit();
+ table.newAppend().appendFile(FILE_A).commit();
+
+ long tAfterCommits =
waitUntilAfter(table.currentSnapshot().timestampMillis());
+ assertThrows(
Review Comment:
Please use junit5: assertThatThrownBy
We are in the process of migrating, and still both versions in the
classpath, but we should use junit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
