abstractdog commented on code in PR #12427:
URL: https://github.com/apache/iceberg/pull/12427#discussion_r2028399067
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -1772,6 +1775,24 @@ public void testNoSchemasOrSpecsToRemove() {
.anyMatch(u -> u instanceof
MetadataUpdate.RemoveSchemas)));
}
+ @TestTemplate
+ public void testCustomWorkerPool() {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
+ // shutdown the executor, cleanExpiredSnapshots should fail
+ executor.shutdownNow();
Review Comment:
makes sense, I just created:
https://github.com/apache/iceberg/pull/12427/commits/144f265bad9b19281466958a0173b84114de1941
I exactly copied testRewriteManifestsWithScanExecutor, which makes sense to
validate that the passed executor is used, but still, the test case will pass
if someone reverts the patch partially, like, only this:
```
private ExecutorService planExecutorService = ThreadPools.getWorkerPool();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
