rdsr commented on pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#issuecomment-695490407
Hi @marton-bod thank you for working on this. I have a few questions
1. I think {{hive-metastore}} module should be unaffected whether we are
running with hive2 or hive3 as {{hive-metastore}} only uses Metatstoreclient
API and I've seen that Metastore upgrades are always backward compatible. I
believe Hive metastore 3 should be backward compatible with Hive metastore
client 2. In that respect we could keep using {{hive-metastore}} module as is.
@pvary, @rdblue thoughts?
2. For the hive code in {{mr}} module which requires changes because of
hive2/hive3 artifacts. Is it possible to move the hive specific code from
{{mr}} module and have 2/3 modules [similar to spark2/spark3] - {{hive-exec}}
for common code, {{hive-exec2}} and {{hive-exec3}} for incompatible code. This
way our {{mr}} modules is simplified and it is also aligned to our discussion
on the mailing list to have an {{hive-exec}} module. This is easier said than
done since it could mean we might have to ship different runtime jars. So best
to get agreement from folks like @rdblue @massdosage and @pvary .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
