marton-bod commented on pull request #1478: URL: https://github.com/apache/iceberg/pull/1478#issuecomment-695769420
Thanks @rdsr for sharing your thoughts! 1.) I agree with you, hive-metastore should be left as is. I haven't changed the hive-metastore module other than fixing the teardown problem in the unit tests, which occurs when using hive 3 dependencies (discussed in https://github.com/apache/iceberg/pull/1455). 2.) I think I've done what you just described, only under different module names. Right now, common code resides in `iceberg-mr`, and incompatible codes have been moved out to `iceberg-mr-hive2` and `icebegr-mr-hive3`. I'm open to renaming the modules to `exec`, sounds like a more suitable name. As for shipping different runtime jars, we might want to create separate runtime modules too just like for spark2 and 3. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
