Guosmilesmile commented on code in PR #12801:
URL: https://github.com/apache/iceberg/pull/12801#discussion_r2049714118
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java:
##########
@@ -189,6 +189,9 @@ public void initializeState(FunctionInitializationContext
context) throws Except
this.recoveryLock = lockFactory.createRecoveryLock();
if (context.isRestored()) {
shouldRestoreTasks = true;
+ } else {
Review Comment:
I think there may be a misunderstanding here.The `lockFactory.createLock()`
just creates an instance of Lock,not actually creating a lock in the external
system.The real external system lock creation is in `tryLock` .And `unlock` is
the real attempt to release the lock in the external system.So the checking
isRestore first to remove the else part can not solve the problem.
So I think the current method is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
