tedyu commented on code in PR #12801:
URL: https://github.com/apache/iceberg/pull/12801#discussion_r2049760666
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManager.java:
##########
@@ -189,6 +189,9 @@ public void initializeState(FunctionInitializationContext
context) throws Except
this.recoveryLock = lockFactory.createRecoveryLock();
if (context.isRestored()) {
shouldRestoreTasks = true;
+ } else {
Review Comment:
Looking at
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/state/,
there is no mentioning of `InterruptedException`. Since we are dealing with
two locks involving `JdbcClientPool`, I am unsure if we may get to the scenario
where `lock` is not held but `recoveryLock` is held.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
