geruh commented on code in PR #12863:
URL: https://github.com/apache/iceberg/pull/12863#discussion_r2053396195
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -347,9 +346,9 @@ private void closeCurrent() throws IOException {
if (currentRows == 0L) {
try {
io.deleteFile(currentFile.encryptingOutputFile());
- } catch (UncheckedIOException e) {
- // the file may not have been created, and it isn't worth
failing the job to clean up,
- // skip deleting
+ } catch (RuntimeException e) {
Review Comment:
This catch is pretty broad what do you think about including some log
message here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
