xiaoxuandev commented on code in PR #12863:
URL: https://github.com/apache/iceberg/pull/12863#discussion_r2069460142
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -345,12 +348,17 @@ private void closeCurrent() throws IOException {
currentWriter.close();
if (currentRows == 0L) {
- try {
- io.deleteFile(currentFile.encryptingOutputFile());
- } catch (UncheckedIOException e) {
- // the file may not have been created, and it isn't worth
failing the job to clean up,
- // skip deleting
- }
+ // the file may not have been created or cannot be deleted, and it
isn't worth failing
+ // the job to clean up, skip deleting
+ Tasks.foreach(currentFile.encryptingOutputFile())
+ .suppressFailureWhenFinished()
+ .onFailure(
+ (file, exc) ->
+ LOG.warn(
+ "Failed to delete the empty file during writer
clean up: {}",
Review Comment:
Good point! Calling it an "uncommitted empty file" makes it much clearer and
avoids confusion, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
