rdblue commented on pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#issuecomment-698497777


   > there is a breaking change in the metastore API between Hive2 and 3
   
   What was the incompatibility? Ideally, we will handle it with reflection to 
avoid needing a different module.
   
   > if the hive2 specific parts are not factored out from iceberg-mr, when 
iceberg-mr-hive3 pulls that in as a dependency, but using Hive3, those couple 
of ObjectInspector classes would not compile
   
   The classes are already compiled. We just have to avoid loading them. So we 
would use different class names for the inspectors between 2 and 3 and load the 
correct one using reflection depending on whether the detected Hive version in 
2 or 3.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to