marton-bod edited a comment on pull request #1478: URL: https://github.com/apache/iceberg/pull/1478#issuecomment-698263424
Thanks @rdblue for your comment. I will look into refactoring the solution to use your suggested approach, which I like. My only concern is that because there is a breaking change in the metastore API between Hive2 and 3, there will have to be two `iceberg-hive-metastore` module versions, one for Hive3 (`iceberg-mr-hive3` would use this for the HiveCatalog tests) and one for Hive2 (the rest of the modules would use this). Not sure, but hopefully it's possible to create a second metastore module in Gradle pointing to the same source files, but using different dependency versions. The other things I'm thinking is that if the hive2 specific parts are not factored out from `iceberg-mr`, when `iceberg-mr-hive3` pulls that in as a dependency, but using Hive3, those couple of ObjectInspector classes would not compile ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
