pvary edited a comment on pull request #1505: URL: https://github.com/apache/iceberg/pull/1505#issuecomment-698563166
> I don't think the reflection option would have any benefit because Hive would still need `ReflectionStorageHandler` in the classpath. This is absolutely true for Hive! I am a little bit concerned about the Spark packages. We might be better of without the iceberg-hive-mr package classes in the iceberg-spark-runtime libraries. The HiveIcebergStorageHandler would be needed only to be present there and would not be used at all, like every other class in the iceberg-hive-mr package if only Spark is used to access the Iceberg tables. If you think that extra few classes is an acceptable compromise to have less complexity, then I would be happy to move forward with the configuration solution. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
