pvary commented on a change in pull request #1505:
URL: https://github.com/apache/iceberg/pull/1505#discussion_r495426780
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java
##########
@@ -325,4 +329,71 @@ public void testNonDefaultDatabaseLocation() throws
IOException, TException {
metastoreClient.dropDatabase(NON_DEFAULT_DATABASE, true, true, true);
}
+ @Test
+ public void testEngineHiveEnabled() throws TException {
+ // Default already created
+ org.apache.hadoop.hive.metastore.api.Table hmsTable =
metastoreClient.getTable(DB_NAME, TABLE_NAME);
+
+ assertHiveEnabled(hmsTable, false);
+
+ catalog.dropTable(TABLE_IDENTIFIER);
+
+ // Enable by hive-conf
Review comment:
Done (kept true/false tests in a single test case, but separated on
config source)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
