stevenzwu commented on code in PR #13010:
URL: https://github.com/apache/iceberg/pull/13010#discussion_r2085907445


##########
open-api/rest-catalog-open-api.py:
##########
@@ -991,6 +991,9 @@ class ValueMap(BaseModel):
 
 class DataFile(ContentFile):
     content: str = Field(..., const=True)
+    first_row_id: Optional[int] = Field(
+        None, alias='first-row-id', description='Starting row ID to assign to 
new rows'

Review Comment:
   nit: to be consistent with the spec, maybe the description can be `The first 
row ID assigned to the first row in the data file`.
   
   applicable to the change below too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to