singhpk234 commented on code in PR #13010:
URL: https://github.com/apache/iceberg/pull/13010#discussion_r2087124167
##########
open-api/rest-catalog-open-api.py:
##########
@@ -991,6 +991,9 @@ class ValueMap(BaseModel):
class DataFile(ContentFile):
content: str = Field(..., const=True)
+ first_row_id: Optional[int] = Field(
+ None, alias='first-row-id', description='Starting row ID to assign to
new rows'
Review Comment:
I re-used the description which we have in the DataFile
https://github.com/apache/iceberg/blob/5d2230ead79da64a8c871a02eb1304a94aaece5c/api/src/main/java/org/apache/iceberg/DataFile.java#L102
The suggested description seems reasonable to me, if you feel strongly,
happy to change in all 3 places, please let me know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
