xxubai commented on code in PR #13056:
URL: https://github.com/apache/iceberg/pull/13056#discussion_r2093832048
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -212,6 +212,26 @@ public void validateReferencedColumns(Schema schema) {
}
}
+ /**
+ * Validate that all referenced columns in the properties are valid columns
in the schema.
+ *
+ * @param schema schema to validate against
+ * @param props properties may contain metrics mode column overrides
+ */
+ public static void validateReferencedColumns(Schema schema, Map<String,
String> props) {
Review Comment:
Make sense.
The method is contracted to a non-public. I also reuse the `from(props,
null, null)`.
@RussellSpitzer PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
