pvary commented on code in PR #13056:
URL: https://github.com/apache/iceberg/pull/13056#discussion_r2095511102
##########
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##########
@@ -191,7 +191,7 @@ public EqualityDeleteWriter<Record> newEqDeleteWriter(
eqDeleteRowSchema,
"Equality delete row schema shouldn't be null when creating
equality-delete writer");
MetricsConfig metricsConfig =
- table != null ? MetricsConfig.forTable(table) :
MetricsConfig.fromProperties(config);
+ table != null ? MetricsConfig.forTable(table) :
MetricsConfig.getDefault();
Review Comment:
Same as above.
##########
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##########
@@ -248,7 +248,7 @@ public PositionDeleteWriter<Record> newPosDeleteWriter(
MetricsConfig metricsConfig =
table != null
? MetricsConfig.forPositionDelete(table)
- : MetricsConfig.fromProperties(config);
+ : MetricsConfig.getDefaultForPosDelete();
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
