jonathanc-n commented on code in PR #1336:
URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2093880705
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -128,6 +128,18 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+ /// Add snapshot summary properties.
+ pub fn add_snapshot_summary_properties(
Review Comment:
If I recall correctly the tested code such as `prop-key` would be under the
more general metadata. The iceberg spec doesn't contain a interface because
snapshot summary properties should be formed from the snapshot directly during
apply
([here](https://github.com/apache/iceberg-rust/blob/cfe2a980b27cda744fab8e78b4550b167b4d4d45/crates/iceberg/src/transaction/snapshot.rs#L310)).
Are you able to link me the code in python that exposes such an interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
