dentiny commented on code in PR #1336:
URL: https://github.com/apache/iceberg-rust/pull/1336#discussion_r2094235270
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -128,6 +128,18 @@ impl<'a> Transaction<'a> {
Ok(self)
}
+ /// Add snapshot summary properties.
+ pub fn add_snapshot_summary_properties(
Review Comment:
I checked java implementation,
- There's a dedicated action to update snapshot summary:
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/SnapshotUpdate.java
- Example usage:
https://github.com/apache/iceberg/blob/c2478968e65368c61799d8ca4b89506a61ca3e7c/spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewritePositionDeleteFilesAction.java#L743-L750
So,
- I think I mis-read the pyiceberg interface, which updates [table
metadata](https://github.com/apache/iceberg-rust/blob/cfe2a980b27cda744fab8e78b4550b167b4d4d45/crates/iceberg/src/spec/table_metadata.rs#L135-L138),
which is not supposed to store customized key-value pairs
- I still think snapshot summary properties is the proper place to place
customized metadata per snapshot
I update the issue and PR description (remove the pyiceberg part) to avoid
mis-leading.
Happy to discuss!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
