Fokko commented on code in PR #1369:
URL: https://github.com/apache/iceberg-rust/pull/1369#discussion_r2105904364
##########
crates/iceberg/src/spec/manifest_list.rs:
##########
@@ -577,7 +575,7 @@ pub struct ManifestFile {
/// A list of field summaries for each partition field in the spec. Each
/// field in the list corresponds to a field in the manifest file’s
/// partition spec.
- pub partitions: Vec<FieldSummary>,
+ pub partitions: Option<Vec<FieldSummary>>,
Review Comment:
There is also a slight semantic difference; when it is omitted, we don't
know anything about the partitions. When it is an empty `Vec`, then it
indicates that it is unpartitioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
