liurenjie1024 commented on code in PR #1369:
URL: https://github.com/apache/iceberg-rust/pull/1369#discussion_r2111508289
##########
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##########
@@ -154,9 +155,19 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> {
_predicate: &BoundPredicate,
) -> crate::Result<bool> {
let field = self.field_summary_for_reference(reference);
+
match &field.lower_bound {
- Some(bound) if datum <= bound => ROWS_CANNOT_MATCH,
- Some(_) => ROWS_MIGHT_MATCH,
+ Some(bound_bytes) => {
+ let bound = ManifestFilterVisitor::bytes_to_datum(
Review Comment:
The cost dependends on the type, but I think it's fine for now since it's
not supposed to be quite expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
