ajantha-bhat commented on PR #13181: URL: https://github.com/apache/iceberg/pull/13181#issuecomment-2920937975
> While this looks like it doesn't introduce any bugs, I don't think there is much reason to make these changes. To me, the tables are harder to read. I would also prefer not to do that because this touches so many tables, making git history and blame harder to use. @rdblue and @RussellSpitzer: Thanks for sharing your thoughts. I initially felt that merging identical columns would make it easier to read and reduce the effort of comparing differences between versions (at least for me). But with this change, it seems to have the opposite effect. So, we are concluding that we don't even have to add one more identical column for v3 and leave the spec as it is now without v3 mention in those tables? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
