amogh-jahagirdar commented on code in PR #13033:
URL: https://github.com/apache/iceberg/pull/13033#discussion_r2126729230
##########
.github/workflows/spark-ci.yml:
##########
@@ -28,38 +28,26 @@ on:
tags:
- 'apache-iceberg-**'
pull_request:
- paths-ignore:
- - '.github/ISSUE_TEMPLATE/**'
- - '.github/workflows/api-binary-compatibility.yml'
- - '.github/workflows/delta-conversion-ci.yml'
- - '.github/workflows/flink-ci.yml'
- - '.github/workflows/hive-ci.yml'
- - '.github/workflows/java-ci.yml'
- - '.github/workflows/jmh-benchmarks-ci.yml'
- - '.github/workflows/kafka-connect-ci.yml'
- - '.github/workflows/labeler.yml'
- - '.github/workflows/license-check.yml'
- - '.github/workflows/open-api.yml'
- - '.github/workflows/publish-snapshot.yml'
- - '.github/workflows/recurring-jmh-benchmarks.yml'
- - '.github/workflows/site-ci.yml'
- - '.github/workflows/stale.yml'
- - '.gitignore'
- - '.asf.yaml'
- - 'dev/**'
- - 'docker/**'
- - 'site/**'
- - 'mr/**'
- - 'flink/**'
- - 'kafka-connect/**'
- - 'docs/**'
- - 'open-api/**'
- - 'format/**'
- - '.gitattributes'
- - '**/README.md'
- - 'CONTRIBUTING.md'
- - '**/LICENSE'
- - '**/NOTICE'
+ paths:
Review Comment:
I think I understand the intent but I'm not sure I completely agree with
changing our CI to work like this.
I see the following in the PR description
>When adding a new module to the project, we might forget to add it to
paths-ignore.
So I agree this is certainly true but I think the inverse is also now
possible and imo has more risk. Isn't it possible that we add a new module,
forget to add it to the paths here and then spark CI never triggers but
could've caught some unforeseen issue?
Since it looks like `paths` can express a file path pattern and can express
both include/exclude, would it make more sense to cast a wide net on the whole
project so then any new module will just be included by default and then
exclude the cases where we know we want to exclude for the particular engine CI
(the open API, AWS, GCS etc)?
@nastra @RussellSpitzer any thoughts on that approach for the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
