manuzhang commented on code in PR #13033:
URL: https://github.com/apache/iceberg/pull/13033#discussion_r2127702048
##########
.github/workflows/spark-ci.yml:
##########
@@ -28,38 +28,26 @@ on:
tags:
- 'apache-iceberg-**'
pull_request:
- paths-ignore:
- - '.github/ISSUE_TEMPLATE/**'
- - '.github/workflows/api-binary-compatibility.yml'
- - '.github/workflows/delta-conversion-ci.yml'
- - '.github/workflows/flink-ci.yml'
- - '.github/workflows/hive-ci.yml'
- - '.github/workflows/java-ci.yml'
- - '.github/workflows/jmh-benchmarks-ci.yml'
- - '.github/workflows/kafka-connect-ci.yml'
- - '.github/workflows/labeler.yml'
- - '.github/workflows/license-check.yml'
- - '.github/workflows/open-api.yml'
- - '.github/workflows/publish-snapshot.yml'
- - '.github/workflows/recurring-jmh-benchmarks.yml'
- - '.github/workflows/site-ci.yml'
- - '.github/workflows/stale.yml'
- - '.gitignore'
- - '.asf.yaml'
- - 'dev/**'
- - 'docker/**'
- - 'site/**'
- - 'mr/**'
- - 'flink/**'
- - 'kafka-connect/**'
- - 'docs/**'
- - 'open-api/**'
- - 'format/**'
- - '.gitattributes'
- - '**/README.md'
- - 'CONTRIBUTING.md'
- - '**/LICENSE'
- - '**/NOTICE'
+ paths:
Review Comment:
> but I think the inverse is also now possible and imo has more risk.
I'm afraid I can't agree. When adding a new module that's related to Spark
module, we are more aware the CI needs to be updated as well. With exclude
path, we may never think of updating Spark CI since it needs to be updated when
adding an unrelated module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
