RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2136103646
##########
core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java:
##########
@@ -114,7 +116,9 @@ public int sizeInBytes() {
if (null == buffer) {
this.buffer = ByteBuffer.wrap(((String)
value).getBytes(StandardCharsets.UTF_8));
}
-
+ if (((String) value).getBytes(StandardCharsets.UTF_8).length <=
SHORT_STRING_LENGTH_MASK) {
Review Comment:
Should we store `getBytes` in a local value like in `writeTo` below? Then we
could use it in the "null" branch and this branch without potentially having to
compute it twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
