RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2138295286
##########
core/src/test/java/org/apache/iceberg/variants/TestPrimitiveWrapper.java:
##########
@@ -57,7 +59,13 @@ public class TestPrimitiveWrapper {
Variants.of(new BigDecimal("9876543210.123456789")), // decimal16
Variants.of(new BigDecimal("-9876543210.123456789")), // decimal16
Variants.of(ByteBuffer.wrap(new byte[] {0x0a, 0x0b, 0x0c, 0x0d})),
- Variants.of("iceberg"),
+ Variants.of("iceberg"), // short string below 255 bytes to test value
offset size of 1
Review Comment:
Another minor note here, We don't actually check that we did a "short
stream" serde here, we probably want an explicit test. For example, we do not
know if these tests are hitting the long or short string paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
