rdblue commented on a change in pull request #1505:
URL: https://github.com/apache/iceberg/pull/1505#discussion_r497790870



##########
File path: 
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -169,6 +173,12 @@ protected void doCommit(TableMetadata base, TableMetadata 
metadata) {
         tbl.getParameters().put("EXTERNAL", "TRUE"); // using the external 
table type also requires this
       }
 
+      // If needed set the 'storate_handler' property to enable query from Hive
+      if (hiveEngineEnabled) {
+        tbl.getParameters().put(hive_metastoreConstants.META_TABLE_STORAGE,
+            "org.apache.iceberg.mr.hive.HiveIcebergStorageHandler");

Review comment:
       Should this be removed if the engine is not enabled? Because this is a 
table property, I don't think it would be automatically removed at any point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to