stevenzwu commented on code in PR #13222:
URL: https://github.com/apache/iceberg/pull/13222#discussion_r2183335091
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -920,6 +920,8 @@ protected Map<String, String> summary() {
@Override
public List<ManifestFile> apply(TableMetadata base, Snapshot snapshot) {
+ Set<DataFile> filesToBeDeleted = filterManager.filesToBeDeleted();
Review Comment:
is this too early? this will include explicitly delete files via `delete(F
file)`. but it won't include the data files removed via `deleteExpression` or
`dropParitition`, which are evaluated in the `filterManifests` step in line
927. Maybe after line 929?
Can we also add a Spark test to cover the `SparkTable.deleteWhere` scenario
that @amogh-jahagirdar
[mentioned](https://github.com/apache/iceberg/pull/13245#pullrequestreview-2980896318).
And maybe also a test covering the `dropPartition` scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
