stevenzwu commented on code in PR #13222:
URL: https://github.com/apache/iceberg/pull/13222#discussion_r2190471989
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -155,6 +161,11 @@ void caseSensitive(boolean newCaseSensitive) {
this.caseSensitive = newCaseSensitive;
}
+ protected void removeDanglingDeletesFor(Set<DataFile> dataFiles) {
Review Comment:
@nastra can you take a look at this comment? It is related to my other
comment about the override. Your and Amogh's comment helped me understand where
my confusion comes from. But if we move this method into the
`DeleteFileFilterManager`, we can avoid the confusion. It does requires that In
the MergingSnapshotProducer, we can use the specific data and delete classes
instead of the base class ManifestFilterManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
