mxm commented on code in PR #13609:
URL: https://github.com/apache/iceberg/pull/13609#discussion_r2225774080
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -109,8 +109,8 @@ public void write(DynamicRecordInternal element, Context
context)
// TODO: Handle precedence correctly for the write
properties coming from
// the sink conf and from the table defaults
Map<String, String> tableWriteProperties =
- Maps.newHashMap(commonWriteProperties);
- tableWriteProperties.putAll(table.properties());
+ Maps.newHashMap(table.properties());
+ tableWriteProperties.putAll(commonWriteProperties);
Review Comment:
Sorry, I think the old version was better. The Flink related configs are
resolved earlier. At this point, we only have the general Iceberg write
properties, for which it doesn't make sense to use the Flink conf parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
