mxm commented on PR #13609: URL: https://github.com/apache/iceberg/pull/13609#issuecomment-3140606058
I think we should be moving configuration code like https://github.com/apache/iceberg/blob/1bd8d5e2de56d05180030b856ce2c50c66ef1f13/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java#L339 into the runtime path, e.g. into the writer, where we can correctly resolve the write properties based on the user-provided properties, Flink config, table properties, and Iceberg-level defaults. It would be nice to use https://github.com/apache/iceberg/blob/1bd8d5e2de56d05180030b856ce2c50c66ef1f13/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/FlinkWriteConf.java#L53 to resolve the write options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
