rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229504828
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetWriter.java:
##########
@@ -50,7 +50,8 @@ public class TestSparkParquetWriter {
private static final Schema SCHEMA =
new Schema(
Types.NestedField.required(1, "id", Types.IntegerType.get()),
- Types.NestedField.required(2, "id_long", Types.LongType.get()));
+ Types.NestedField.required(2, "id_long", Types.LongType.get()),
+ Types.NestedField.required(3, "v", Types.VariantType.get()));
Review Comment:
This schema is only used for `testFpp`, and that doesn't even use the
schema. It creates a writer and then validates the FPP setting using
reflection. I think you can revert this since it doesn't actually test any
variant code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
