rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2229573912
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2189,6 +2194,54 @@ public void testTableWithInt96Timestamp() throws
IOException {
}
}
+ @Test
+ public synchronized void testVariantTableSupport() {
Review Comment:
I don't think that this test suite should be modified. See
https://github.com/apache/iceberg/pull/13219/files#r2229566081 for more
information, but the short argument is that how tables are loaded through
`IcebergSource` is orthogonal to types.
It looks like this test suite has become a place for tests that no one knows
where to put, like INT96 support and table imports. We should avoid adding new
tests here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
