aihuaxu commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2230074995
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/AvroDataTest.java:
##########
@@ -605,4 +723,172 @@ public void testRowLineage() throws Exception {
record.copy(Map.of("id", 4L, "data", "d", "_row_id", 1_001L)),
record.copy(Map.of("id", 5L, "data", "e"))));
}
+
+ @Test
+ public void testUnshreddedVariant() throws IOException {
+ Assumptions.assumeThat(supportsVariant()).as("Variant support is not
implemented").isTrue();
+
+ Schema schema =
+ new Schema(required(0, "id", LongType.get()), optional(1, "data",
Types.VariantType.get()));
+
+ writeAndValidate(schema);
+ }
+
+ @Test
+ public void testShreddedVariant() throws IOException {
Review Comment:
OK. So basically we just need to test out the VariantReaderBuilder and the
conversion from Variant to VariantVal. The shredding logic should be covered by
TestVariantReaders.
I'm removing them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
