aihuaxu commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2230146958
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -184,6 +184,8 @@ private static String convertToTypeString(Type type) {
final Types.MapType mapType = type.asMapType();
return String.format(
"map<%s,%s>", convert(mapType.keyType()),
convert(mapType.valueType()));
+ case VARIANT:
+ return "variant";
Review Comment:
Sounds good. I'm removing the test for now. We can add `DataTest` for
`HiveCatalog` in the following PR if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
