rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2232233715
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/GenericsHelpers.java:
##########
@@ -296,6 +320,134 @@ private static void assertEqualsUnsafe(Types.MapType map,
Map<?, ?> expected, Ma
}
}
+ static void assertEquals(Variant expected, VariantVal actual) {
+ VariantMetadata actualMetadata =
+
VariantMetadata.from(ByteBuffer.wrap(actual.getMetadata()).order(ByteOrder.LITTLE_ENDIAN));
+ VariantTestUtil.assertEqual(expected.metadata(), actualMetadata);
+
+ org.apache.spark.types.variant.Variant sparkVariant =
+ new org.apache.spark.types.variant.Variant(actual.getValue(),
actual.getMetadata());
+ assertEquals(expected.value(), sparkVariant);
Review Comment:
I'd prefer to revert this to the previous logic. See the comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
