rdblue commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2237509872
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/RandomData.java:
##########
@@ -332,6 +340,20 @@ public Object map(Types.MapType map, Supplier<Object>
keyResult, Supplier<Object
return result;
}
+ public VariantVal variant(Types.VariantType type) {
Review Comment:
Okay, so this is implementing a visitor method? In that case, it's missing
the `@Override` annotation. I thought this was just a helper method that was
going to be called from elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
