amogh-jahagirdar commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2238008612
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/ParquetWithSparkSchemaVisitor.java:
##########
@@ -152,6 +153,14 @@ public static <T> T visit(DataType sType, Type type,
ParquetWithSparkSchemaVisit
} finally {
visitor.fieldNames.pop();
}
+ } else if (sType instanceof VariantType) {
+ // TODO: Use LogicalTypeAnnotation.variantType().equals(annotation)
when VARIANT type is
+ // added to Parquet
+ // Preconditions.checkArgument(
+ // sType instanceof VariantType, "Invalid variant: %s is not a
VariantType", sType);
Review Comment:
I meant specifically removing this commented out part:
```
/ Preconditions.checkArgument(
// sType instanceof VariantType, "Invalid variant: %s is not a
VariantType", sType);
```
I know we're waiting on the logical type definition so I'm good with
keeping the other ToDo part so that when the parquet type is added we can
uncomment it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
