nastra commented on code in PR #13219:
URL: https://github.com/apache/iceberg/pull/13219#discussion_r2239344782
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/source/DataFrameWriteTestBase.java:
##########
@@ -98,10 +100,10 @@ private Dataset<Row>
createDataset(List<GenericData.Record> records, Schema sche
}
// verify that the dataframe matches
- assertThat(rows).hasSameSizeAs(records);
- Iterator<GenericData.Record> recordIter = records.iterator();
+ assertThat(rows.size()).isEqualTo(records.size());
Review Comment:
it is generally better to use `assertThat(rows).hasSameSizeAs(records);` as
that will show you the content of rows/records when the assertion ever fails.
@aihuaxu was there a particular reason why this check was changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
