Kurtiscwright commented on PR #1579: URL: https://github.com/apache/iceberg-rust/pull/1579#issuecomment-3151906186
> Thnks for working on this @Kurtiscwright. The changes make sense to me, but I would also expect seting more `initial-default`'s like here: https://github.com/apache/iceberg-rust/pull/1482/files#diff-2bde106cc8d1cc2e8c7a327cb117fb8dc5e4b143898360504f6e585d1904acbbR238 Thank you for taking the time to review the PR @liurenjie1024 and @Fokko. My understanding (could be completely incorrect) is that with the annotations of #default where the schema is declared always provides that value unless overridden. For example, whenever ManifestContentType is called you always get a value of `0` unless its overridden. I am open to adding more initial-default's if my explanation above is incorrect. I tried adding extremely explicit tests to make sure that the assumption holds. If we agree on this approach I would be happy to work on a fast follow PR to align all the other default values to this same implementation. Documentation: https://doc.rust-lang.org/std/default/trait.Default.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
