Fokko commented on PR #1579: URL: https://github.com/apache/iceberg-rust/pull/1579#issuecomment-3159540095
Thanks @liurenjie1024 for pinging me here. I think I did not a great job at explaining my original intent at the issue. This PR is great, and allows converting the V1 structs into V2, which I think is also valuable. My goal was to have an Avro reader that both can read V1 and V2, and read them into a V2 struct right away. This way we don't have to go through the hassle of looking up the format-version in the Avro metadata, and then pick the right reader. For example, if the `sequence-number` is missing because it is a V1 entry, we can just set it to 0. I'm okay merging this one, and then we can close the gap in a separate PR. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
