manuzhang commented on code in PR #13837:
URL: https://github.com/apache/iceberg/pull/13837#discussion_r2281194879
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -86,6 +86,16 @@ public interface RewriteTablePath extends
Action<RewriteTablePath, RewriteTableP
*/
RewriteTablePath stagingLocation(String stagingLocation);
+ /**
+ * Whether to skip saving the file list location.
+ *
+ * @param skipFileList true to skip saving the file list, false to include it
+ * @return this instance for method chaining
+ */
+ default RewriteTablePath saveFileList(boolean skipFileList) {
Review Comment:
The method name and the parameter name have opposite meaning.
`saveFileList(true)` is actually not to save file list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
