nastra commented on code in PR #13837:
URL: https://github.com/apache/iceberg/pull/13837#discussion_r2290270365
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -86,6 +86,16 @@ public interface RewriteTablePath extends
Action<RewriteTablePath, RewriteTableP
*/
RewriteTablePath stagingLocation(String stagingLocation);
+ /**
+ * Whether to skip saving the file list location.
+ *
+ * @param skipFileList true to skip saving the file list, false to include it
+ * @return this instance for method chaining
+ */
+ default RewriteTablePath skipFileList(boolean skipFileList) {
Review Comment:
why not call this `createFileList` that always defaults to true. Also
without reading the javadoc it's not clear what `skip` actually refers to. Does
it skip scanning that file or creating/deleting/x?
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -112,5 +122,15 @@ interface Result {
/** Name of latest metadata file version */
String latestVersion();
+
+ /** count of rewrite delete files, default value is 0 */
Review Comment:
```suggestion
/** count of rewritten delete files, default value is 0 */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
