RussellSpitzer commented on code in PR #12228:
URL: https://github.com/apache/iceberg/pull/12228#discussion_r2363274764
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -299,6 +309,14 @@ protected MetricsReporter metricsReporter() {
return metricsReporter;
}
+ // Atomically set given metadata as current
+ protected void setAsCurrent(
Review Comment:
I'm not sure it's super clear how this works from the signature. IMHO, an
implementation of this shouldn't care what "base" is. It should either be
"setAsCurrent if empty or setAsCurrentRegardless"
In my above snippet maybe something like
```
if (overwrite)
setAsCurrent(Identifier, Location)
} else {
setAsCurrentIfEmpty(identifier, location)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
